993aacaea5Update comment to reflect that a bug has been filed with PHP-analyzer.
jgen
2014-04-24 16:55:34 -04:00
c4dcba1e91Explicitly check for the existence of these properties before attempting to use them.
jgen
2014-04-24 05:37:26 -04:00
7e41194b7fShish you are too clever for scrutinizer-ci.
jgen
2014-04-24 05:29:02 -04:00
ce524e8729This variable does exist, it is actually pulled from the database. Making it explicit for the linter.
jgen
2014-04-24 05:25:12 -04:00
e2f5c7a6ecCheck for null, just in case.
jgen
2014-04-24 05:09:38 -04:00
0501e05cffComment out dead code/vars.
jgen
2014-04-24 05:09:16 -04:00
332c8538b7Change the function syntax to quiet JSHint.
jgen
2014-04-24 04:46:23 -04:00
868f8c9225Commenting out dead variables and dead code.
jgen
2014-04-24 04:44:28 -04:00
f9c8a1720eComment out dead variables.
jgen
2014-04-24 04:41:13 -04:00
f67220f64bFrom stack-overflow: The 'var' keyword is for declaring class variables in PHP4. It works in PHP5 but can raise an E_STRICT warning in from version 5.0.0 up to version 5.1.2, as it has been deprecated. Changing to public as that is really what these variables are anyways.
jgen
2014-04-24 04:36:05 -04:00
67c087c30fFrom stack-overflow: The 'var' keyword is for declaring class variables in PHP4. It works in PHP5 but can raise an E_STRICT warning in from version 5.0.0 up to version 5.1.2, as it has been deprecated. Changing to public as that is really what these variables are anyways.
jgen
2014-04-24 04:30:58 -04:00
dbe30ad37dRename variable to make it more clear.
jgen
2014-04-24 01:36:30 -04:00
afc01fda5fPrevent scrutinizer-ci from complaining about these fall-thoughs.
jgen
2014-04-24 01:36:04 -04:00
506e699f8aNot sure if we really need the triple equals.
jgen
2014-04-24 01:15:30 -04:00
866d39a68eThe 'tags' box actually has a different ID.
jgen
2014-04-24 01:15:03 -04:00
51c145d5c9Some more linting on the bookmarklet.js file.
jgen
2014-04-24 01:08:47 -04:00
4b90faf89dEven more linting of JS files.
jgen
2014-04-24 00:55:14 -04:00
a105090039Some more JS linting.
jgen
2014-04-23 23:39:09 -04:00
887f963e17Add the jshint comment to alter how scrutinzer-ci deals with the js.
jgen
2014-04-23 23:38:53 -04:00
2dc6e054c8These sorts are necessary on the header arrays, otherwise the relative priority of certain headers is not respected.
jgen
2014-04-23 23:28:05 -04:00
b775c007cdGive these HTML headers some slight priority over the default value of 50.
jgen
2014-04-23 23:07:10 -04:00
a0ab3864c0Push the headers for the chatbox even further down to make sure that jQuery is already loaded.
jgen
2014-04-23 23:01:51 -04:00
8cdf919827More linting. This time of the JavaScript for the chat-box extension.
jgen
2014-04-23 22:43:42 -04:00
0bd031a269Merge branch 'develop' of github.com:jgen/shimmie2 into linting
jgen
2014-04-23 22:42:30 -04:00
5eaa637bbbMerge branch 'develop' of git://github.com/shish/shimmie2 into develop
jgen
2014-04-23 22:23:53 -04:00
44d0e56c97Merge pull request #406 from jgen/video_thumb
Shish
2014-04-20 11:25:24 +01:00
ef3daaf388Merge pull request #411 from jgen/develop
Shish
2014-04-20 11:21:43 +01:00
21e1359b86Avoid short open tag for PHP.
jgen
2014-04-20 05:07:26 -04:00
60980c8839One more jQuery reference.
jgen
2014-04-20 05:04:45 -04:00
a7ba0f887bAgain, the chatbox needs help from the jQuery migrate plugin.
jgen
2014-04-20 05:00:59 -04:00
2df54b911aDon't use short open tags for PHP as they are not turned on by default in production environments.
jgen
2014-04-20 05:00:34 -04:00
e2516fa5cfChatbox should be fixed now. The chatbox extension actually needs some functionality that was removed from jQuery versions 1.9 and up. When Shimmie's version of jQuery was bumped up to 1.11 this actually broke the chatbox.
jgen
2014-04-20 04:51:19 -04:00
880840623aNeed to ensure that this html header is added last.
jgen
2014-04-20 04:36:25 -04:00
717401ccabRemoving this as jQuery is already included in Shimmie now.
jgen
2014-04-20 04:35:33 -04:00
8b698e1b6fRevert this commit.
jgen
2014-04-20 04:29:11 -04:00
54362a49c6Fix the broken chatbox issue.
jgen
2014-04-20 04:25:08 -04:00