james/fembooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

simplify user_can_edit_user -- many nested if/else's to one if

Browse Source
This commit is contained in:
Shish 2014-08-24 20:43:12 +01:00
parent b1d634a8de
commit fc4bd27529
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
ext/user/main.php
View File

@ -494,27 +494,20 @@ class UserPage extends Extension {
private function user_can_edit_user(User $a, User $b) { private function user_can_edit_user(User $a, User $b) {
if($a->is_anonymous()) { if($a->is_anonymous()) {
$this->theme->display_error(401, "Error", "You aren't logged in"); $this->theme->display_error(401, "Error", "You aren't logged in");
return false;
} }
if($a->name == $b->name) {
if(
($a->name == $b->name) ||
($b->can("protected") && $a->class->name == "admin") ||
(!$b->can("protected") && $a->can("edit_user_info"))
) {
return true; return true;
} }
if($b->can("protected")) {
if($a->class->name == "admin") {
return true;
}
else {
$this->theme->display_error(401, "Error", "You need to be an admin to change other people's details");
}
}
else { else {
if($a->can("edit_user_info")) { $this->theme->display_error(401, "Error", "You need to be an admin to change other people's details");
return true; return false;
}
else {
$this->theme->display_error(401, "Error", "You need to be an admin to change other people's details");
}
} }
return false;
} }
private function redirect_to_user(User $duser) { private function redirect_to_user(User $duser) {