From caa6d59a873015721ccf549112a616894bf79f62 Mon Sep 17 00:00:00 2001 From: Shish Date: Mon, 23 Sep 2013 19:23:54 +0100 Subject: [PATCH 1/2] log base was changed years ago, comment never got updated --- ext/tag_list/main.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/tag_list/main.php b/ext/tag_list/main.php index 7209beac..b8e7e976 100644 --- a/ext/tag_list/main.php +++ b/ext/tag_list/main.php @@ -292,7 +292,7 @@ class TagList extends Extension { ORDER BY count DESC, tag ASC ", array("tags_min"=>$tags_min)); - $html = "Results grouped by loge(n)"; + $html = "Results grouped by log10(n)"; $lastLog = ""; foreach($tag_data as $row) { $h_tag = html_escape($row['tag']); From 63aa4c633016ed5935092c5a06856ab39db28665 Mon Sep 17 00:00:00 2001 From: Shish Date: Sun, 8 Dec 2013 10:52:50 +0000 Subject: [PATCH 2/2] avoid possibility of infinite loop in bbcode parsing --- ext/bbcode/main.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ext/bbcode/main.php b/ext/bbcode/main.php index cfa240b9..4b10a5c7 100644 --- a/ext/bbcode/main.php +++ b/ext/bbcode/main.php @@ -99,6 +99,8 @@ class BBCode extends FormatterExtension { $end = strpos($text, "[/spoiler]"); if($end === false) break; + if($end < $start) break; + $beginning = substr($text, 0, $start); $middle = str_rot13(substr($text, $start+$l1, ($end-$start-$l1))); $ending = substr($text, $end + $l2, (strlen($text)-$end+$l2)); @@ -124,6 +126,8 @@ class BBCode extends FormatterExtension { $end = strpos($text, "[/code]", $start); if($end === false) break; + if($end < $start) break; + $beginning = substr($text, 0, $start); $middle = base64_encode(substr($text, $start+$l1, ($end-$start-$l1))); $ending = substr($text, $end + $l2, (strlen($text)-$end+$l2));