From f91bdfac02698484b23307c64a4eaff4ec2c85f8 Mon Sep 17 00:00:00 2001
From: Shish <shish@shishnet.org>
Date: Mon, 26 Oct 2020 17:13:41 +0000
Subject: [PATCH] booleanise private_messages

---
 ext/pm/main.php | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/ext/pm/main.php b/ext/pm/main.php
index 5328dea3..ee3b3b77 100644
--- a/ext/pm/main.php
+++ b/ext/pm/main.php
@@ -74,12 +74,12 @@ class PrivMsg extends Extension
 				sent_date TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
 				subject VARCHAR(64) NOT NULL,
 				message TEXT NOT NULL,
-				is_read SCORE_BOOL NOT NULL DEFAULT SCORE_BOOL_N,
+				is_read BOOLEAN NOT NULL DEFAULT FALSE,
 				FOREIGN KEY (from_id) REFERENCES users(id) ON DELETE CASCADE,
 				FOREIGN KEY (to_id) REFERENCES users(id) ON DELETE CASCADE
 			");
             $database->execute("CREATE INDEX private_message__to_id ON private_message(to_id)");
-            $config->set_int("pm_version", 2);
+            $config->set_int("pm_version", 3);
             log_info("pm", "extension installed");
         }
 
@@ -91,7 +91,14 @@ class PrivMsg extends Extension
 			ADD FOREIGN KEY (from_id) REFERENCES users(id) ON DELETE CASCADE,
 			ADD FOREIGN KEY (to_id) REFERENCES users(id) ON DELETE CASCADE;");
             $config->set_int("pm_version", 2);
-            log_info("pm", "extension installed");
+            log_info("pm", "extension upgraded");
+        }
+
+        if ($config->get_int("pm_version") < 3) {
+            log_info("pm", "Updating is_read boolean");
+            $database->standardise_boolean("private_message", "is_read");
+            $config->set_int("pm_version", 3);
+            log_info("pm", "extension upgraded");
         }
     }
 
@@ -146,7 +153,7 @@ class PrivMsg extends Extension
                         } elseif (($pm["to_id"] == $user->id) || $user->can(Permissions::VIEW_OTHER_PMS)) {
                             $from_user = User::by_id((int)$pm["from_id"]);
                             if ($pm["to_id"] == $user->id) {
-                                $database->execute("UPDATE private_message SET is_read='Y' WHERE id = :id", ["id" => $pm_id]);
+                                $database->execute("UPDATE private_message SET is_read=true WHERE id = :id", ["id" => $pm_id]);
                                 $cache->delete("pm-count-{$user->id}");
                             }
                             $this->theme->display_message($page, $from_user, $user, new PM($pm));
@@ -241,7 +248,7 @@ class PrivMsg extends Extension
 					FROM private_message
 					WHERE to_id = :to_id
 					AND is_read = :is_read
-			", ["to_id" => $user->id, "is_read" => "N"]);
+			", ["to_id" => $user->id, "is_read" => false]);
             $cache->set("pm-count:{$user->id}", $count, 600);
         }
         return $count;