AHA! This bug took ages to track down, as the trigger was in a completely different system to the error message... Many, many thanks to zshall for managing to reproduce the error, then narrowing it down to a single line \o/

This commit is contained in:
Shish 2010-03-21 02:17:16 +00:00
parent 5abee51db7
commit f4cbd8b24f

View File

@ -323,7 +323,13 @@ function _count_execs($db, $sql, $inputarray) {
fclose($fp); fclose($fp);
} }
else { else {
log_error("core", "failed to open sql.log for appending"); # WARNING:
# SQL queries happen before the event system is fully initialised
# (eg, "select theme from config" happens before "load themes"),
# so using the event system to report an error will create some
# really weird looking bugs.
#
#log_error("core", "failed to open sql.log for appending");
} }
} }
if (!is_array($inputarray)) $_execs++; if (!is_array($inputarray)) $_execs++;