From cc95eb5deb89b06e71911f4116a3d1d79f53fe4a Mon Sep 17 00:00:00 2001
From: jgen <jgen.tech@gmail.com>
Date: Mon, 13 May 2013 20:40:01 -0400
Subject: [PATCH] Some more small speed tweaks.

---
 core/event.class.php     |  6 ++++--
 core/imageboard.pack.php | 13 ++++++++-----
 ext/wiki/main.php        |  2 +-
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/core/event.class.php b/core/event.class.php
index 2f3b84dd..f68a1336 100644
--- a/core/event.class.php
+++ b/core/event.class.php
@@ -39,7 +39,7 @@ class PageRequestEvent extends Event {
 		}
 
 		// if path is not specified, use the default front page
-		if(strlen($path) === 0) {
+		if(empty($path)) {   /* empty is faster than strlen */
 			$path = $config->get_string('front_page');
 		}
 
@@ -147,7 +147,9 @@ class CommandEvent extends Event {
 
 		$opts = array();
 		$log_level = SCORE_LOG_WARNING;
-		for($i=1; $i<count($args); $i++) {
+        $arg_count = count($args);
+        
+		for($i=1; $i<$arg_count; $i++) {
 			switch($args[$i]) {
 				case '-u':
 					$user = User::by_name($args[++$i]);
diff --git a/core/imageboard.pack.php b/core/imageboard.pack.php
index c978c732..3bb57f71 100644
--- a/core/imageboard.pack.php
+++ b/core/imageboard.pack.php
@@ -148,7 +148,9 @@ class Image {
 	public static function count_images($tags=array()) {
 		assert(is_array($tags));
 		global $database;
-		if(count($tags) == 0) {
+        $tag_count = count($tags);
+        
+		if($tag_count == 0) {
 			$total = $database->cache->get("image-count");
 			if(!$total) {
 				$total = $database->get_one("SELECT COUNT(*) FROM images");
@@ -156,7 +158,7 @@ class Image {
 			}
 			return $total;
 		}
-		else if(count($tags) == 1 && !preg_match("/[:=><\*\?]/", $tags[0])) {
+		else if($tag_count == 1 && !preg_match("/[:=><\*\?]/", $tags[0])) {
 			$term = Tag::resolve_alias($tags[0]);
 			return $database->get_one(
 				$database->scoreql_to_sql("SELECT count FROM tags WHERE SCORE_STRNORM(tag) = SCORE_STRNORM(:tag)"),
@@ -578,13 +580,14 @@ class Image {
 				$_flexihash = new Flexihash();
 				foreach(explode(",", $opts) as $opt) {
 					$parts = explode("=", $opt);
+                    $parts_count = count($parts);
 					$opt_val = "";
 					$opt_weight = 0;
-					if(count($parts) == 2) {
+					if($parts_count == 2) {
 						$opt_val = $parts[0];
 						$opt_weight = $parts[1];
 					}
-					elseif(count($parts) == 1) {
+					elseif($parts_count == 1) {
 						$opt_val = $parts[0];
 						$opt_weight = 1;
 					}
@@ -652,7 +655,7 @@ class Image {
 				$positive = false;
 				$term = substr($term, 1);
 			}
-			if(strlen($term) == 0) {
+			if(strlen($term) === 0) {
 				continue;
 			}
 
diff --git a/ext/wiki/main.php b/ext/wiki/main.php
index bb2f4837..4026c2bd 100644
--- a/ext/wiki/main.php
+++ b/ext/wiki/main.php
@@ -83,7 +83,7 @@ class Wiki extends Extension {
 	public function onPageRequest(PageRequestEvent $event) {
 		global $config, $page, $user;
 		if($event->page_matches("wiki")) {
-			if(is_null($event->get_arg(0)) || strlen(trim($event->get_arg(0))) == 0) {
+			if(is_null($event->get_arg(0)) || strlen(trim($event->get_arg(0))) === 0) {
 				$title = "Index";
 			}
 			else {