james/fembooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

The page class now supports both HTML headers and HTTP headers.

Browse Source 
From the comment:
FIXME: should be $page->blah
This commit is contained in:
green-ponies (jgen) 2011-08-30 16:24:10 -04:00
parent 19a3a5a6f9
commit bd31bcd79a
2 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
core/page.class.php
View File

@ -109,6 +109,7 @@ class Page {
var $subheading = ""; var $subheading = "";
var $quicknav = ""; var $quicknav = "";
var $html_headers = array(); var $html_headers = array();
var $http_headers = array();
var $blocks = array(); var $blocks = array();
/** @publicsection */ /** @publicsection */
@ -144,8 +145,9 @@ class Page {
/** /**
* Add a http header to be sent to the client. * Add a http header to be sent to the client.
*/ */
public function add_header($line) { public function add_http_header($line, $position=50) {
die("Function is not impliemented yet."); while(isset($this->http_headers[$position])) $position++;
$this->http_headers[$position] = $line;
} }
/** /**
@ -164,9 +166,17 @@ class Page {
*/ */
public function display() { public function display() {
global $page; global $page;
add_http_header("Content-type: {$this->type}", 1);
add_http_header("X-Powered-By: SCore-".SCORE_VERSION, 2);
header("Content-type: {$this->type}"); if (!headers_sent()) {
header("X-Powered-By: SCore-".SCORE_VERSION); foreach($this->http_headers as $head){
header($head);
}
} else {
print "Error: Headers have already been sent to the client.";
}
switch($this->mode) { switch($this->mode) {
case "page": case "page":

8
ext/image/main.php
View File

@ -367,13 +367,13 @@ class ImageIO extends SimpleExtension {
} }
$gmdate_mod = gmdate('D, d M Y H:i:s', filemtime($file)) . ' GMT'; $gmdate_mod = gmdate('D, d M Y H:i:s', filemtime($file)) . ' GMT';
// FIXME: should be $page->blah
if($if_modified_since == $gmdate_mod) { if($if_modified_since == $gmdate_mod) {
header("HTTP/1.0 304 Not Modified"); $page->add_http_header("HTTP/1.0 304 Not Modified",3);
} }
else { else {
header("Last-Modified: $gmdate_mod"); /* FIXME: The Expires date Needs to be admin-configurable */
header("Expires: Fri, 2 Sep 2101 12:42:42 GMT"); // War was beginning $page->add_http_header("Last-Modified: $gmdate_mod");
$page->add_http_header("Expires: Fri, 2 Sep 2101 12:42:42 GMT"); // War was beginning
} }
} }
else { else {