From a0588bd8f8d6b863bc19a9f6ddfc2d8d599f0208 Mon Sep 17 00:00:00 2001
From: Shish <shish@shishnet.org>
Date: Tue, 21 May 2019 23:12:52 +0100
Subject: [PATCH] empty list rather than 404 for invalid autocompletes

---
 ext/autocomplete/main.php | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/ext/autocomplete/main.php b/ext/autocomplete/main.php
index 0138b469..d3ed6900 100644
--- a/ext/autocomplete/main.php
+++ b/ext/autocomplete/main.php
@@ -13,13 +13,20 @@ class AutoComplete extends Extension {
 
 		if($event->page_matches("api/internal/autocomplete")) {
 			if(!isset($_GET["s"])) return;
+
+			$page->set_mode("data");
+			$page->set_type("application/json");
+
 			$s = strtolower($_GET["s"]);
 			if(
 				$s == '' ||
-				$s == '_' ||
-				$s == '%' ||
+				$s[0] == '_' ||
+				$s[0] == '%' ||
 				strlen($s) > 32
-			) return;
+			) {
+				$page->set_data("{}");
+				return;
+			}
 
 			//$limit = 0;
 			$cache_key = "autocomplete-$s";
@@ -44,8 +51,6 @@ class AutoComplete extends Extension {
 				$database->cache->set($cache_key, $res, 600);
 			}
 
-			$page->set_mode("data");
-			$page->set_type("application/json");
 			$page->set_data(json_encode($res));
 		}