From 862a84677fb4057d76365fb02e9c5a908dacea76 Mon Sep 17 00:00:00 2001
From: Daku <admin@codeanimu.net>
Date: Mon, 7 Mar 2016 01:37:53 +0000
Subject: [PATCH] add docs column, showing what extensions have documentation
 previously it made every ext name into a link to /ext_doc, regardless if it
 had docs or not

---
 ext/ext_manager/theme.php | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/ext/ext_manager/theme.php b/ext/ext_manager/theme.php
index 06883e77..de939f65 100644
--- a/ext/ext_manager/theme.php
+++ b/ext/ext_manager/theme.php
@@ -7,26 +7,31 @@ class ExtManagerTheme extends Themelet {
 			".make_form(make_link("ext_manager/set"))."
 				<table id='extensions' class='zebra sortable'>
 					<thead>
-						<tr>$h_en<th>Name</th><th>Description</th></tr>
+						<tr>
+							$h_en
+							<th>Name</th>
+							<th>Docs</th>
+							<th>Description</th>
+						</tr>
 					</thead>
 					<tbody>
 		";
 		foreach($extensions as $extension) {
 			if(!$editable && $extension->visibility == "admin") continue;
 
-			$h_name = html_escape(empty($extension->name) ? $extension->ext_name : $extension->name);
+			$h_name        = html_escape(empty($extension->name) ? $extension->ext_name : $extension->name);
 			$h_description = html_escape($extension->description);
-			if($extension->enabled === TRUE) $h_enabled = " checked='checked'";
-			else if($extension->enabled === FALSE) $h_enabled = "";
-			else $h_enabled = " disabled checked='checked'";
-			$h_link = make_link("ext_doc/".url_escape($extension->ext_name));
+			$h_link        = make_link("ext_doc/".url_escape($extension->ext_name));
+			$h_enabled     = ($extension->enabled === TRUE ? " checked='checked'" : ($extension->enabled === FALSE ? "" : " disabled checked='checked'"));
+			$h_enabled_box = $editable ? "<td><input type='checkbox' name='ext_".html_escape($extension->ext_name)."'$h_enabled></td>" : "";
+			$h_docs        = ($extension->documentation ? "<a href='$h_link'>■</a>" : ""); //TODO: A proper "docs" symbol would be preferred here.
 
-			$h_en = $editable ? "<td><input type='checkbox' name='ext_".html_escape($extension->ext_name)."'$h_enabled></td>" : "";
 			$html .= "
-				<tr>
-					$h_en
-					<td>".($extension->documentation ? "<a href='$h_link'>$h_name</a>" : $h_name)."</td>
-					<td style='text-align: left;'>$h_description</td>
+				<tr data-ext='{$extension->ext_name}'>
+					{$h_enabled_box}
+					<td>{$h_name}</td>
+					<td>{$h_docs}</td>
+					<td style='text-align: left;'>{$h_description}</td>
 				</tr>";
 		}
 		$h_set = $editable ? "<tfoot><tr><td colspan='5'><input type='submit' value='Set Extensions'></td></tr></tfoot>" : "";