From 5a93e650c166d93fb932803185325bab51efb99f Mon Sep 17 00:00:00 2001 From: Shish Date: Sat, 23 Jun 2012 23:25:53 +0100 Subject: [PATCH] make sure featured image object is fully populated before caching, else it still lazy-queries tags each time --- ext/featured/main.php | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ext/featured/main.php b/ext/featured/main.php index 21fdb319..0ed6918d 100644 --- a/ext/featured/main.php +++ b/ext/featured/main.php @@ -60,10 +60,13 @@ class Featured extends Extension { global $config, $database, $page, $user; $fid = $config->get_int("featured_id"); if($fid > 0) { - $image = $database->cache->get("featured_image_object"); - if(empty($image)) { + $image = $database->cache->get("featured_image_object-$fid"); + if($image === false) { $image = Image::by_id($fid); - $database->cache->set("featured_image_object", $image, 60); + if($image) { // make sure the object is fully populated before saving + $image->get_tag_array(); + } + $database->cache->set("featured_image_object-$fid", $image, 60); } if(!is_null($image)) { if(class_exists("Ratings")) {