james/fembooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #488 from jgen/master

Browse Source 
Only examine response headers if we actually have them & remove duplicate 'class' attribute.
This commit is contained in:
Shish 2015-06-01 15:58:36 +01:00
commit 4ebcf449e2
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/util.inc.php
View File

@ -960,11 +960,6 @@ function transload($url, $mfile) {
fwrite($fp, $data);
fclose($fp);
//
// Scrutinizer-ci complains that $http_response_header does not exist,
// however, $http_response_header is actually a super-global.
// I have filed a bug with PHP-Analyzer here: https://github.com/scrutinizer-ci/php-analyzer/issues/212
//
$headers = http_parse_headers(implode("\n", $http_response_header));
return $headers;

2
ext/tag_edit/theme.php
View File

@ -49,7 +49,7 @@ class TagEditTheme extends Themelet {
<td>
".($user->can("edit_image_tag") ? "
<span class='view'>$h_tag_links</span>
<input class='edit' type='text' name='tag_edit__tags' value='$h_tags' class='autocomplete_tags' id='tag_editor'>
<input class='edit autocomplete_tags' type='text' name='tag_edit__tags' value='$h_tags' id='tag_editor'>
" : "
$h_tag_links
")."

3
ext/upload/main.php
View File

@ -364,9 +364,10 @@ class Upload extends Extension {
$tmp_filename = tempnam(ini_get('upload_tmp_dir'), "shimmie_transload");
// transload() returns Array or Bool, depending on the transload_engine.
$headers = transload($url, $tmp_filename);
$s_filename = findHeader($headers, 'Content-Disposition');
$s_filename = is_array($headers) ? findHeader($headers, 'Content-Disposition') : null;
$h_filename = ($s_filename ? preg_replace('/^.*filename="([^ ]+)"/i', '$1', $s_filename) : null);
$filename = $h_filename ?: basename($url);