diff --git a/core/database.class.php b/core/database.class.php index a22c838c..eb00e1ab 100644 --- a/core/database.class.php +++ b/core/database.class.php @@ -229,7 +229,7 @@ class MemcacheCache implements CacheEngine { class APCCache implements CacheEngine { var $hits=0, $misses=0; - public function __construct() {} + public function __construct($args) {} public function get($key) { assert(!is_null($key)); diff --git a/core/util.inc.php b/core/util.inc.php index 8eae8fbb..b2dfa436 100644 --- a/core/util.inc.php +++ b/core/util.inc.php @@ -867,6 +867,9 @@ function transload($url, $mfile) { fwrite($fp, $data); fclose($fp); + // Scrutinizer-ci complains that $http_response_header not defined. + // However, it is auto defined by PHP. + // See: http://us2.php.net/manual/en/reserved.variables.httpresponseheader.php $headers = http_parse_headers(implode("\n", $http_response_header)); return $headers; diff --git a/ext/artists/main.php b/ext/artists/main.php index 7aea77ad..f74022d5 100644 --- a/ext/artists/main.php +++ b/ext/artists/main.php @@ -805,7 +805,7 @@ class Artists extends Extension { $urls = $_POST["urls"]; $userID = $user->id; - $artistID = ""; + //$artistID = ""; //// WE CHECK IF THE ARTIST ALREADY EXISTS ON DATABASE; IF NOT WE CREATE if(!$this->artist_exists($name)) diff --git a/ext/blotter/theme.php b/ext/blotter/theme.php index 872f550a..23395bc5 100644 --- a/ext/blotter/theme.php +++ b/ext/blotter/theme.php @@ -106,7 +106,7 @@ class BlotterTheme extends Themelet { // Reset variables: $i_open = ""; $i_close = ""; - $id = $entries[$i]['id']; + //$id = $entries[$i]['id']; $messy_date = $entries[$i]['entry_date']; $clean_date = date("y/m/d", strtotime($messy_date)); $entry_text = $entries[$i]['entry_text']; diff --git a/ext/chatbox/js/yshout.js b/ext/chatbox/js/yshout.js index b60f189f..be4fb4b9 100644 --- a/ext/chatbox/js/yshout.js +++ b/ext/chatbox/js/yshout.js @@ -380,7 +380,7 @@ YShout.prototype = { } for (var j = 0; j < same.length; j++) { - $('#' + same[j].id).fadeTo(this.animSpeed, .8).fadeTo(this.animSpeed, 1); + $('#' + same[j].id).fadeTo(this.animSpeed, 0.8).fadeTo(this.animSpeed, 1); } }, diff --git a/ext/pools/main.php b/ext/pools/main.php index e8637e1b..965fb98e 100644 --- a/ext/pools/main.php +++ b/ext/pools/main.php @@ -806,6 +806,7 @@ class Pools extends Extension { $images = explode(" ", $images); $poolID = $entry['pool_id']; $imageArray = ""; + $newAction = -1; if($entry['action'] == 0) { // READ ENTRIES @@ -826,6 +827,10 @@ class Pools extends Extension { $imageArray .= " ".$imageID; $newAction = 0; } + } else { + // FIXME: should this throw an exception instead? + log_error("pools", "Invalid history action."); + continue; // go on to the next one. } $count = $database->get_one("SELECT COUNT(*) FROM pool_images WHERE pool_id=:pid", array("pid"=>$poolID)); diff --git a/ext/tag_list/main.php b/ext/tag_list/main.php index bb4c39fb..3677c98a 100644 --- a/ext/tag_list/main.php +++ b/ext/tag_list/main.php @@ -48,7 +48,7 @@ class TagList extends Extension { else if($event->page_matches("api/internal/tag_list/complete")) { if(!isset($_GET["s"])) return; - $limit = 0; + //$limit = 0; $limitSQL = ""; $SQLarr = array("search"=>$_GET["s"]."%"); if(isset($_GET["limit"]) && $_GET["limit"] !== 0){ @@ -321,7 +321,7 @@ class TagList extends Extension { private function build_tag_list() { global $database; - $tags_min = $this->get_tags_min(); + //$tags_min = $this->get_tags_min(); $tag_data = $database->get_all("SELECT tag,count FROM tags ORDER BY count DESC, tag ASC LIMIT 9"); $html = "