james/fembooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

use is_int instead of is_numeric if we want to reject numeric strings, should fix #681

Browse Source
This commit is contained in:
Shish 2019-09-29 17:58:56 +01:00
parent 160f673060
commit 0f4a0275b5
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/database.php
View File

@ -213,7 +213,7 @@ class Database
// $stmt = $this->db->prepare($query); // $stmt = $this->db->prepare($query);
if (!array_key_exists(0, $args)) { if (!array_key_exists(0, $args)) {
foreach ($args as $name=>$value) { foreach ($args as $name=>$value) {
if (is_numeric($value)) { if (is_int($value)) {
$stmt->bindValue(':'.$name, $value, PDO::PARAM_INT); $stmt->bindValue(':'.$name, $value, PDO::PARAM_INT);
} else { } else {
$stmt->bindValue(':'.$name, $value, PDO::PARAM_STR); $stmt->bindValue(':'.$name, $value, PDO::PARAM_STR);

6
core/imageboard/image.php
View File

@ -81,9 +81,9 @@ class Image
} }
$this->locked = bool_escape($this->locked); $this->locked = bool_escape($this->locked);
assert(is_numeric($this->id)); assert(is_int($this->id));
assert(is_numeric($this->height)); assert(is_int($this->height));
assert(is_numeric($this->width)); assert(is_int($this->width));
} }
} }

2
core/polyfills.php
View File

@ -503,7 +503,7 @@ function bool_escape($input): bool
*/ */
if (is_bool($input)) { if (is_bool($input)) {
return $input; return $input;
} elseif (is_numeric($input)) { } elseif (is_int($input)) {
return ($input === 1); return ($input === 1);
} else { } else {
$value = filter_var($input, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE); $value = filter_var($input, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE);